Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add net8.0-windows to WinAppSdk #165

Merged
merged 27 commits into from
Feb 27, 2024
Merged

Add net8.0-windows to WinAppSdk #165

merged 27 commits into from
Feb 27, 2024

Conversation

Arlodotexe
Copy link
Member

This PR adds net8.0-windows10.0.22621.0 as a supported TargetFramework on all WinAppSdk components.

Closes #164

@Arlodotexe Arlodotexe added the dev loop ➰ For issues that impact the core dev-loop of building experiments label Jan 29, 2024
@Arlodotexe Arlodotexe self-assigned this Jan 29, 2024
@Arlodotexe Arlodotexe mentioned this pull request Jan 29, 2024
Merged
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Feb 20, 2024 •
edited
Loading

Still blocked on the issue detailed here, but msbuild extras has been fully removed from all targets except UWP, and all resulting errors have been fixed.

A few (new?) warnings that need resolved, either here or in a separate PR:

Release tracking and diagnostic descriptor formatting:

        D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\Diagnostics\DiagnosticDescriptors.cs(216,9): warning RS2008: Enable analyzer release tracking for the analyzer project containing rule 'TKSMPL0015' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md) [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\CommunityToolkit.Tooling.SampleGen.csproj]
    D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\Diagnostics\DiagnosticDescriptors.cs(201,9): warning RS2008: Enable analyzer release tracking for the analyzer project containing rule 'TKSMPL0014' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md) [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\CommunityToolkit.Tooling.SampleGen.csproj]

A warning about an EnforceExtendedAnalyzerRules property that needs to be enabled for our source generators:

        D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\ToolkitSampleMetadataGenerator.Documentation.cs(17,22): warning RS1036: 'CommunityToolkit.Tooling.SampleGen.ToolkitSampleMetadataGenerator': A project containing analyzers or source generators should specify the property '<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>' [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\CommunityToolkit.Tooling.SampleGen\CommunityToolkit.Tooling.SampleGen.csproj]

A few conflicts with System.Collections.Immutable on the test heads that need resolved:

      "D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\ProjectTemplate.sln" (default target) (1:2) ->
  "D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Tests.WinAppSdk\ProjectTemplate.Tests.WinAppSdk.csproj" (default target) (6:6) ->
  (ResolveAssemblyReferences target) -> 
    C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2382,5): warning MSB3277: Found conflicts between different versions of "System.Collections.Immutable" that could not be resolved. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Tests.WinAppSdk\ProjectTemplate.Tests.WinAppSdk.csproj]
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2382,5): warning MSB3277: There was a conflict between "System.Collections.Immutable, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" and "System.Collections.Immutable, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Tests.WinAppSdk\ProjectTemplate.Tests.WinAppSdk.csproj]

Wasm head might need an explicit reference to the latest Microsoft.CodeAnalysis packages:

     "D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Wasm\ProjectTemplate.Wasm.csproj" (default target) (8:6) ->
    (CoreCompile target) -> 
      CSC : warning CS9057: The analyzer assembly 'C:\Program Files\dotnet\sdk\8.0.201\Sdks\Microsoft.NET.Sdk.Razor\source-generators\Microsoft.CodeAnalysis.Razor.Compiler.SourceGenerators.dll' references version '4.9.0.0' of the compiler, which is newer than the currently running version '4.8.0.0'. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Wasm\ProjectTemplate.Wasm.csproj]
      D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Wasm\Uno.UI.SourceGenerato

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Feb 21, 2024 •
edited
Loading

Looks like our blocker was resolved by this commit, but some lingering issues still remain regarding package conflicts and new analyzer warnings (see here).

@Arlodotexe Arlodotexe mentioned this pull request Feb 21, 2024
Closed
@Arlodotexe
Copy link
Member Author

Looks like something broke when EnforceExtendedAnalyzerRules was enabled on the source generators. Tests aren't able to see emitted Diagnostics for some reason, looking into it. More info here: dotnet/roslyn-analyzers#6115

@Arlodotexe Arlodotexe mentioned this pull request Feb 27, 2024
Merged
@Arlodotexe Arlodotexe merged commit c7ae0a0 into main Feb 27, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the upgrade/wasdk/net8-windows branch February 27, 2024 23:03
@Arlodotexe Arlodotexe mentioned this pull request Mar 1, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to .NET 8 in Wasdk
2 participants
@Arlodotexe @michael-hawker